Add _numpy_helper.py to implement numpy.fft helper functions
#229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndgrigorian
requested review from
antonwolfy,
ekomarova and
xaleryb
as code owners
ndgrigorian
force-pushed
the
further-work-to-prevent-circular-dependencies
branch
from
28ab191 to
aab894a
Compare
to avoid circular dependencies, also vendor (i)fftshift and (r)fftfreq from scipy
numpy constructor argument signatures were updated with a device keyword in numpy 2 and pylint fails as a result
ndgrigorian
force-pushed
the
further-work-to-prevent-circular-dependencies
branch
from
227a1b8 to
0802c25
Compare
|
with these changes, all of the following now work with followed by calling the respective namespaces for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes copying over (with some modification) the
numpy.ffthelper functionsfftshift,ifftshift,fftfreq, andrfftfreq.These functions are problematic in creating circular dependencies when Intel's patched NumPy is used with SciPy. Furthermore, lazy importing creates a situation where
scipy.fft = mkl_fft.interfaces.scipy_fftwill reimportscipy.fftand remove the module override.